Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rapportere til Slack status på CI/CD/E2E #230

Closed
2 of 3 tasks
Tracked by #74
elsand opened this issue Nov 7, 2023 · 1 comment
Closed
2 of 3 tasks
Tracked by #74

Rapportere til Slack status på CI/CD/E2E #230

elsand opened this issue Nov 7, 2023 · 1 comment
Assignees
Labels
monitoring Issue related to logging and monitoring

Comments

@elsand
Copy link
Member

elsand commented Nov 7, 2023

Introduksjon

Vi trenger monitorering av bygg/unit test, deploy/migrering og E2E-tester i Github som varsler til Slack

Beskrivelse

Når det settes i gang et bygg m/unit testing fra PR, eller bygg m/unit test fra CI, deploy til hvilket som helst miljø samt kjøring av E2E-tester for det aktuelle miljøet, skal det rapporteres til #dialogporten-cicd på Slack

Implementasjon

Se https://github.com/slackapi/slack-github-action

Oppgaver

Preview Give feedback
@elsand elsand added the monitoring Issue related to logging and monitoring label Nov 7, 2023
@elsand elsand changed the title Rapportere til Github status på CI/CD/E2E Rapportere til Slack status på CI/CD/E2E Dec 18, 2023
@arealmaas arealmaas self-assigned this Sep 24, 2024
arealmaas added a commit that referenced this issue Oct 8, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

- Alerts us if the k6-tests are failing in the specified channel
(team-dialogporten-github-backend for now.)

## Related Issue(s)

- #230 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Added a notification system that sends Slack messages when K6 tests
fail, improving incident response.
- **Chores**
- Updated workflow configuration to transition from deprecated actions
to new ones for K6 testing.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
arealmaas added a commit that referenced this issue Oct 10, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

## Related Issue(s)

- #230 

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a Slack message template for pipeline failures, enhancing
communication during CI/CD processes.
- Added a `send-slack-message` job to CI/CD workflows for staging,
production, and main environments to notify teams of failures.

- **Bug Fixes**
- Improved visibility into deployment issues through automated Slack
notifications.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@arealmaas
Copy link
Collaborator

Awaiting uploading of the test result when it's supported in the github action: slackapi/slack-github-action#92

arealmaas added a commit that referenced this issue Oct 11, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

- Seems to be a classic case of "smør på flesk" to have both the
pipeline failing slack message and the k6-tests slack message. Won't
give any additional value until we can upload the test result file in
the message and make it sweeter:
slackapi/slack-github-action#92 Removing for
now.
- Tweaked the template a bit for the pipeline slack message
- This is a good start, and we can expand by adding more info on the
slack-message, for now posting a status for each workflow.

<img width="673" alt="image"
src="https://github.com/user-attachments/assets/d2dccb8c-2e1f-44da-add1-dd8a0a9af2f7">

## Related Issue(s)

- #230

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Enhanced Slack notifications for pipeline statuses with improved
structure and clarity.
- Introduced a new GitHub Actions workflow for sending CI/CD status
updates to Slack, capturing results from multiple jobs.
- Updated existing Slack message jobs to report on both success and
failure conditions across various environments.

- **Bug Fixes**
- Removed unnecessary Slack message sending on K6 test failures,
streamlining the workflow.

- **Documentation**
- Updated environment variables and job conditions for better clarity
and functionality in CI/CD processes.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
monitoring Issue related to logging and monitoring
Projects
None yet
Development

No branches or pull requests

2 participants