Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate registration of Validator #103

Closed
zzzsz opened this issue Aug 30, 2024 · 2 comments · Fixed by #112
Closed

Duplicate registration of Validator #103

zzzsz opened this issue Aug 30, 2024 · 2 comments · Fixed by #112
Labels
bug Something isn't working

Comments

@zzzsz
Copy link

zzzsz commented Aug 30, 2024

In pkix.crl.init.py, in function create_pkix_crl_validator_container,
general_name.GeneralNameIpAddressSyntaxValidator() is registered twice

def create_pkix_crl_validator_container(
        decoding_validators, validators):
    decoding_validator_container = [
        validation.ValidatorContainer(
            validators=decoding_validators, path='certificateList'
        )
    ]

    validators += [
        PrintableStringConstraintValidator(),
        crl_validator.VersionPresenceValidator(),
        crl_validator.CorrectVersionValidator(),
        crl_extension.CrlNumberPresenceValidator(),
        crl_extension.AuthorityKeyIdentifierPresenceValidator(),
        crl_validator.SignatureAlgorithmMatchValidator(),
        crl_extension.CrlReasonCodeCriticalityValidator(),
        time.UtcTimeCorrectSyntaxValidator(),
        time.GeneralizedTimeCorrectSyntaxValidator(),
        pkix.CertificateSerialNumberValidator(),
        crl_extension.CrlNumberValueValidator(),
        NamedBitStringMinimalEncodingValidator(),
        general_name.GeneralNameIpAddressSyntaxValidator(),
        general_name.GeneralNameMailboxAddressSyntaxValidator(),
        general_name.GeneralNameIpAddressSyntaxValidator(),
        general_name.GeneralNameUriSyntaxValidator(),
    ]

    return validation.ValidatorContainer(
        validators=decoding_validator_container + validators
    )
@CBonnell
Copy link
Collaborator

CBonnell commented Sep 3, 2024

Thanks, I'll get this fixed in the next release.

@CBonnell CBonnell added the bug Something isn't working label Sep 3, 2024
@zzzsz zzzsz closed this as completed Sep 4, 2024
@CBonnell
Copy link
Collaborator

CBonnell commented Sep 4, 2024

Keeping this open for tracking until resolved in the next release.

@CBonnell CBonnell reopened this Sep 4, 2024
@zzzsz zzzsz closed this as completed Sep 6, 2024
@zzzsz zzzsz reopened this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants