Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the whole presetRef when listing observations #39

Open
tomasciccola opened this issue Oct 22, 2024 · 2 comments
Open

Return the whole presetRef when listing observations #39

tomasciccola opened this issue Oct 22, 2024 · 2 comments

Comments

@tomasciccola
Copy link

tomasciccola commented Oct 22, 2024

Description

Currently when listing observations through the web API we return associated tags with that observation. Some presets (categories) don't have tags which means a hard to categorize observation. Ideally, observations returned by the API should include the presetRef resolved (so, not returning the id, but the whole preset doc).
A thing to decide is if the preset itself resolves its references, since a preset has fieldRef and iconRef.
It would be useful as a first feature (if its possible) to just resolve the fieldRef, iconRef doesn't seem a priority at a glance.
If the complexity of solving this is big, a compromise would be to just return the name of the preset

@gmaclennan
Copy link
Member

FYI presets/categories should always have tags, and each preset/categories tags should be different. We need to enforce that when building presets and/or reading presets. It's necessary for exploring / filtering and exporting data in the future.

@EvanHahn EvanHahn transferred this issue from digidem/comapeo-core Nov 27, 2024
@EvanHahn
Copy link
Contributor

FYI presets/categories should always have tags, and each preset/categories tags should be different. We need to enforce that when building presets and/or reading presets. It's necessary for exploring / filtering and exporting data in the future.

@gmaclennan Does this mean that we don't need to implement this right now? I think the answer is "no, we don't need to, because reading from tags is sufficient". But I might be misunderstanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants