You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the currently implementation it's possible to hit a race condition while closing a project:
constclosePromise=project.close()// Note: no awaitconstproject=manager.getProject(projectId)awaitclosePromise()awaitproject.observation.getMany()// will fail because project is closed
Needs proper state management to fix: e.g. project.state: 'opening' | 'opened' | 'closing' | 'closed'. Then maybe rather than events based doing in getProject():
This is fine to not address as a priority - we only close projects in tests. Just leaving this here in case we run into this issue in tests in the future.
The text was updated successfully, but these errors were encountered:
Description
Non-urgent follow-up to #375.
With the currently implementation it's possible to hit a race condition while closing a project:
Needs proper state management to fix: e.g.
project.state: 'opening' | 'opened' | 'closing' | 'closed'
. Then maybe rather than events based doing ingetProject()
:This is fine to not address as a priority - we only close projects in tests. Just leaving this here in case we run into this issue in tests in the future.
The text was updated successfully, but these errors were encountered: