-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block non-local connections on mdns server #68
Labels
Comments
I was wondering how can we test this. Should we have a publicly accessible node that does mdns and connects to a predefined topic, so we can reject it on a test? Or is there already a mdns testnet that we can use? |
This was referenced Apr 10, 2023
tomasciccola
moved this from 🏗 In progress
to 👀 In review
in Mapeo - Sprint 2023 (Archived)
Apr 17, 2023
Closed
This should be fixed in the latest implementation |
github-project-automation
bot
moved this from 👀 In review
to ✅ Done
in Mapeo - Sprint 2023 (Archived)
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We create a tcp server for listening to mdns connections, but theoretically this could receive connections from outside the local network.
We should reject/block incoming connections from non-local addresses. We can maybe do this by checking
socket.remoteAddress
against private IP ranges with something like https://github.com/mafintosh/bogonThe reason for doing this is a security precaution, particularly if we are sending invites to peers discovered through mdns, and we want to be sure that incoming connections are local network only.
The text was updated successfully, but these errors were encountered: