Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Loop playback at the end of the section" is not functioning #262

Open
srsridh opened this issue Feb 14, 2019 · 8 comments
Open

"Loop playback at the end of the section" is not functioning #262

srsridh opened this issue Feb 14, 2019 · 8 comments
Labels
Milestone

Comments

@srsridh
Copy link

srsridh commented Feb 14, 2019

Even after the "Loop playback at the end of the section" under the settings option is checked, the audio does not play in loop. It continues to move to the next bubble.

@stephenwf
Copy link
Member

On the latest branch here, if you select a bubble and let it play all of the way to the end of the bubble, when it gets to the end it will restart from the beginning. Currently, by default, if you skip ahead more than 1 second it breaks the loop. This was intended to allow users to break out of the loop, say if they wanted to skip to a completely new section without selecting a bubble. To get back into the loop you can simply click the bubble again.

Maybe it should only break out of the loop if you click a point outside of the bubble.

@srsridh
Copy link
Author

srsridh commented Feb 14, 2019

Actually, I did not skip when I tested this. I let the music play and still it did not play again in loop

@stephenwf stephenwf added this to the 1.x milestone Mar 6, 2019
@srsridh
Copy link
Author

srsridh commented Mar 13, 2019

Hi Stephen,

I wanted to follow up with you regarding this. I tested this again on (https://master--iiif-timeliner.netlify.com/) and the same issue is going on. I showed it to Maria also. When the "Loop playback at the end of the section" is checked, it still goes to the next section

@stephenwf
Copy link
Member

Hi @srsridh which browser are you using to test, I'm still unable to replicate this bug at the moment

@srsridh
Copy link
Author

srsridh commented Mar 13, 2019

Hi, Kindly test it out in (https://master--iiif-timeliner.netlify.com/)

@srsridh
Copy link
Author

srsridh commented Mar 15, 2019

Hi @stephenwf , it is actually a bug. If we let the whole loop play, without interference it works as expected. Say, if we move the marker a bit inside the bubble, i think the "loop playback" option gets disabled and goes to the next bubble.

@stephenwf
Copy link
Member

Hi @srsridh at the moment that is expected behaviour:

Currently, by default, if you skip ahead more than 1 second it breaks the loop. This was intended to allow users to break out of the loop, say if they wanted to skip to a completely new section without selecting a bubble. To get back into the loop you can simply click the bubble again.

Maybe we need to change this to be if a user click outside of the bubble to break the looping behaviour.

@mcwhitaker
Copy link

mcwhitaker commented Mar 18, 2019

@stephenwf - we had this same problem with breaking a loop for playlists in Avalon. It was hard to fix. If this is equally hard to fix, let's say it is a feature: manually intervening breaks the loop. However, one needs a way to reset the looping.

In trying to see how to reset the looping, I tested this in the master--iiif-timeliner branch. I could not make it to loop even without clicking anywhere.

Steps:

  1. load an mp3 file
  2. create a short bubble
  3. go to settings and set looping on, apply.
  4. using the player control, move the playhead to the beginning of the short bubble
  5. start playing

This did not loop for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants