Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't convert Traktor files where one or more entries are without a location, or the location file is blank #21

Closed
alza-bitz opened this issue Oct 2, 2019 · 0 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@alza-bitz
Copy link
Contributor

alza-bitz commented Oct 2, 2019

From a user submitted error report, it would appear that Traktor allows entries without a location, or entries with a blank location file (I don't know why Traktor allows this).

I'm not sure it makes sense to convert these entries, by also allowing downstream items (and consequently Rekordbox tracks) without a location, by making it optional everywhere.. I'd rather make location optional for Traktor, and leave it required everywhere else (until I'm proved otherwise).

This can be handled by filtering the collection to only those entries with a location and a non-blank location file (other entries won't be converted).

The user submitted Traktor collection only had a few entries in ~32,000 without a location or a blank location file, so this seems sensible (although I only have one example to work from!)

@alza-bitz alza-bitz changed the title Can't convert Traktor files where one or more entries don't have a location Can't convert Traktor files where one or more entries are without a location Oct 2, 2019
@alza-bitz alza-bitz changed the title Can't convert Traktor files where one or more entries are without a location Can't convert Traktor files where one or more entries are without a location, or the location file is blank Oct 3, 2019
@alza-bitz alza-bitz added the bug Something isn't working label Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant