You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This code assumes that every cause would be a BedrockError that would be explicitly marked as public.
It is not common practice to wrap every error that might be included in a BedrockError in another BedrockError.
I think the practical solution here is to say that the cause should be logged if the outer BedrockError is marked as public.
This of course could mean that a cause leaks data that should not be exposed in logs. However, the current state of affairs makes it impossible to debug applications issues in deployments.
The text was updated successfully, but these errors were encountered:
mattcollier
changed the title
Loggine BedrockError.cause needs to be improved
Logging BedrockError.cause needs to be improved
Nov 4, 2022
bedrock/lib/util.js
Lines 80 to 82 in eaac0b9
This code assumes that every
cause
would be a BedrockError that would be explicitly marked as public.It is not common practice to wrap every error that might be included in a BedrockError in another BedrockError.
I think the practical solution here is to say that the
cause
should be logged if the outer BedrockError is marked as public.This of course could mean that a
cause
leaks data that should not be exposed in logs. However, the current state of affairs makes it impossible to debug applications issues in deployments.The text was updated successfully, but these errors were encountered: