-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSA Proof wrong canonicalization #174
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
RsaSignature2018 is broken in VC context v1. More info in: w3c/vc-data-model#778
For that reason, in vc.js the canonicalization of a RsaSignature2018 proof is not being expanded. The result of the library is like this:
when it should be like this:
After some discussion in w3c/vc-data-model#1151, seems that the correct solution to preserve interoperability with another implementations, is to expand the items as they should be.
For that, I am proposing a specific fix that can be done at LinkedDataSignature or JwsLinkedDataSignature.
I picture something like, if "RsaSignature2018" then apply a fix to expand correctly during canonicalization. Might be done in the createVerifyData method. At JwsLinkedDataSignature level, will be less "intrusive", and we could override that specific method.
Reproducer: https://github.com/fabrii/dc-playground
Thanks!
The text was updated successfully, but these errors were encountered: