Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to fill entire BG when 'contrast'? #25

Open
indfnzo opened this issue Jul 1, 2017 · 3 comments
Open

Option to fill entire BG when 'contrast'? #25

indfnzo opened this issue Jul 1, 2017 · 3 comments

Comments

@indfnzo
Copy link

indfnzo commented Jul 1, 2017

Pardon the title, it's a little hard explaining this in a phrase.

Is it possible to make the highlighter highlight the entire line (e.g: the current line highlighter) of scopes set to contrast?

screen

See: black contrasted comment looks bad (black background is too tight).

It would be great if it would highlight the entire line instead (like the current line highlighter, see: yellow).

Thanks, I hope my issue made sense. :)

@sharedprophet
Copy link
Collaborator

Unfortunately the highlighter does not allow for altering the text color. We could combine it with scopes for the text color, but there could be non-comment text on the same line as a comment, so naively highlighting the entire line wouldn't work. How would you want it to look in that case?

@indfnzo
Copy link
Author

indfnzo commented Jul 2, 2017

I was actually thinking about something like this:

But then I realized it might be too much trouble given the benefit it would bring. If there would be at least some way to not make the contrasted comments look cut off (add some padding of some sort), I'd be satisfied with that :)

@sharedprophet
Copy link
Collaborator

I'll see what I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants