Skip to content

Commit 67eabc7

Browse files
committed
fix: update TargetLoadBalancerIDs type from any to string
1 parent 6f5b012 commit 67eabc7

File tree

2 files changed

+8
-22
lines changed

2 files changed

+8
-22
lines changed

internal/networking/load_balancers_tools.go

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -91,16 +91,9 @@ func (l *LoadBalancersTool) createLoadBalancer(ctx context.Context, req mcp.Call
9191

9292
// Global load balancer arguments
9393
if lbType == "GLOBAL" {
94-
// Parse target load balancer IDs
95-
targetLoadBalancerIDs, _ := args["TargetLoadBalancerIDs"].([]any)
96-
if len(targetLoadBalancerIDs) > 0 {
97-
targetIDs := make([]string, len(targetLoadBalancerIDs))
98-
for i, id := range targetLoadBalancerIDs {
99-
if id, ok := id.(string); ok {
100-
targetIDs[i] = string(id)
101-
}
102-
}
103-
lbr.TargetLoadBalancerIDs = targetIDs
94+
targetLoadBalancerIDs, ok := args["TargetLoadBalancerIDs"].([]string)
95+
if ok && len(targetLoadBalancerIDs) > 0 {
96+
lbr.TargetLoadBalancerIDs = targetLoadBalancerIDs
10497
}
10598

10699
// Parse GLB settings
@@ -337,16 +330,9 @@ func (l *LoadBalancersTool) updateLoadBalancer(ctx context.Context, req mcp.Call
337330
}
338331

339332
if lbType == "GLOBAL" {
340-
// Parse target load balancer IDs
341-
targetLoadBalancerIDs, _ := args["TargetLoadBalancerIDs"].([]any)
342-
if len(targetLoadBalancerIDs) > 0 {
343-
targetIDs := make([]string, len(targetLoadBalancerIDs))
344-
for i, id := range targetLoadBalancerIDs {
345-
if id, ok := id.(string); ok {
346-
targetIDs[i] = string(id)
347-
}
348-
}
349-
lbr.TargetLoadBalancerIDs = targetIDs
333+
targetLoadBalancerIDs, ok := args["TargetLoadBalancerIDs"].([]string)
334+
if ok && len(targetLoadBalancerIDs) > 0 {
335+
lbr.TargetLoadBalancerIDs = targetLoadBalancerIDs
350336
}
351337

352338
// Parse GLB settings

internal/networking/load_balancers_tools_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func TestLoadBalancersTool_createLoadBalancer(t *testing.T) {
162162
"IsEnabled": true,
163163
},
164164
},
165-
"TargetLoadBalancerIDs": []any{"target-lb-1", "target-lb-2"},
165+
"TargetLoadBalancerIDs": []string{"target-lb-1", "target-lb-2"},
166166
},
167167
mockSetup: func(m *MockLoadBalancersService) {
168168
m.EXPECT().
@@ -808,7 +808,7 @@ func TestLoadBalancersTool_updateLoadBalancer(t *testing.T) {
808808
"IsEnabled": true,
809809
},
810810
},
811-
"TargetLoadBalancerIDs": []any{"target-lb-3", "target-lb-4"},
811+
"TargetLoadBalancerIDs": []string{"target-lb-3", "target-lb-4"},
812812
},
813813
mockSetup: func(m *MockLoadBalancersService) {
814814
m.EXPECT().

0 commit comments

Comments
 (0)