Skip to content

Commit e649dcb

Browse files
fix(tests): fix: tests which call HTTP endpoints directly with the example parameters
1 parent 6e40dc3 commit e649dcb

File tree

1 file changed

+12
-27
lines changed

1 file changed

+12
-27
lines changed

tests/test_client.py

Lines changed: 12 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
from gradientai import GradientAI, AsyncGradientAI, APIResponseValidationError
2525
from gradientai._types import Omit
2626
from gradientai._models import BaseModel, FinalRequestOptions
27-
from gradientai._constants import RAW_RESPONSE_HEADER
2827
from gradientai._exceptions import APIStatusError, APITimeoutError, GradientAIError, APIResponseValidationError
2928
from gradientai._base_client import (
3029
DEFAULT_TIMEOUT,
@@ -721,30 +720,21 @@ def test_parse_retry_after_header(self, remaining_retries: int, retry_after: str
721720

722721
@mock.patch("gradientai._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
723722
@pytest.mark.respx(base_url=base_url)
724-
def test_retrying_timeout_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
723+
def test_retrying_timeout_errors_doesnt_leak(self, respx_mock: MockRouter, client: GradientAI) -> None:
725724
respx_mock.get("/v2/gen-ai/agents/uuid/versions").mock(side_effect=httpx.TimeoutException("Test timeout error"))
726725

727726
with pytest.raises(APITimeoutError):
728-
self.client.get(
729-
"/v2/gen-ai/agents/uuid/versions",
730-
cast_to=httpx.Response,
731-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
732-
)
727+
client.agents.versions.with_streaming_response.list(uuid="uuid").__enter__()
733728

734729
assert _get_open_connections(self.client) == 0
735730

736731
@mock.patch("gradientai._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
737732
@pytest.mark.respx(base_url=base_url)
738-
def test_retrying_status_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
733+
def test_retrying_status_errors_doesnt_leak(self, respx_mock: MockRouter, client: GradientAI) -> None:
739734
respx_mock.get("/v2/gen-ai/agents/uuid/versions").mock(return_value=httpx.Response(500))
740735

741736
with pytest.raises(APIStatusError):
742-
self.client.get(
743-
"/v2/gen-ai/agents/uuid/versions",
744-
cast_to=httpx.Response,
745-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
746-
)
747-
737+
client.agents.versions.with_streaming_response.list(uuid="uuid").__enter__()
748738
assert _get_open_connections(self.client) == 0
749739

750740
@pytest.mark.parametrize("failures_before_success", [0, 2, 4])
@@ -1548,30 +1538,25 @@ async def test_parse_retry_after_header(self, remaining_retries: int, retry_afte
15481538

15491539
@mock.patch("gradientai._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
15501540
@pytest.mark.respx(base_url=base_url)
1551-
async def test_retrying_timeout_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
1541+
async def test_retrying_timeout_errors_doesnt_leak(
1542+
self, respx_mock: MockRouter, async_client: AsyncGradientAI
1543+
) -> None:
15521544
respx_mock.get("/v2/gen-ai/agents/uuid/versions").mock(side_effect=httpx.TimeoutException("Test timeout error"))
15531545

15541546
with pytest.raises(APITimeoutError):
1555-
await self.client.get(
1556-
"/v2/gen-ai/agents/uuid/versions",
1557-
cast_to=httpx.Response,
1558-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
1559-
)
1547+
await async_client.agents.versions.with_streaming_response.list(uuid="uuid").__aenter__()
15601548

15611549
assert _get_open_connections(self.client) == 0
15621550

15631551
@mock.patch("gradientai._base_client.BaseClient._calculate_retry_timeout", _low_retry_timeout)
15641552
@pytest.mark.respx(base_url=base_url)
1565-
async def test_retrying_status_errors_doesnt_leak(self, respx_mock: MockRouter) -> None:
1553+
async def test_retrying_status_errors_doesnt_leak(
1554+
self, respx_mock: MockRouter, async_client: AsyncGradientAI
1555+
) -> None:
15661556
respx_mock.get("/v2/gen-ai/agents/uuid/versions").mock(return_value=httpx.Response(500))
15671557

15681558
with pytest.raises(APIStatusError):
1569-
await self.client.get(
1570-
"/v2/gen-ai/agents/uuid/versions",
1571-
cast_to=httpx.Response,
1572-
options={"headers": {RAW_RESPONSE_HEADER: "stream"}},
1573-
)
1574-
1559+
await async_client.agents.versions.with_streaming_response.list(uuid="uuid").__aenter__()
15751560
assert _get_open_connections(self.client) == 0
15761561

15771562
@pytest.mark.parametrize("failures_before_success", [0, 2, 4])

0 commit comments

Comments
 (0)