Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include RD when displaying a list of VRFs in a form #1141

Closed
nonsbe opened this issue May 8, 2017 · 6 comments
Closed

Include RD when displaying a list of VRFs in a form #1141

nonsbe opened this issue May 8, 2017 · 6 comments
Labels
type: feature Introduction of new functionality to the application
Milestone

Comments

@nonsbe
Copy link

nonsbe commented May 8, 2017

A detailed description of the proposed functionality:

The option to create duplicate VRF names on the same or different Tenants is already allowed, but when you create a new prefix you have to select the according VRF. Is it possible to set a prefix with the Site name in front of the VRF selection. This would imply that a VRF should also contain a Tenant site and not only a Tenant.
In this manner its easier to select the according VRF.

Another option could be to dynamically filter the available VRFs for the new prefix based on Tenant/Site selection.

A use case for the feature:

We have a tenant with 10 sites and our CPE equipment is placed in each site. For example, each site contains a VRF named GuestVRF.
When you have to create the according prefix for the GuestVRF for Site A it's hard to choose the according VRF at this time.

VRF Structure IPAM:

  • Tenant 1 Site A: GuestVRF - Prefix A
  • Tenant 1 Site B: GuestVRF - Prefix B
  • Tenant 2 Site A: GuestVRF - Prefix C

Kr,
Niels

@nonsbe
Copy link
Author

nonsbe commented May 10, 2017

It seems this is not a solution as well because if you have a VRF with a leased line, you want to be able to track the IP addresses for both sites in one VRF.

Anyway a prefix of the Tenant name in the selection box for VRFs in prefix creation would be helpful.

Anyone other suggestions?

@jeremystretch
Copy link
Member

The problem appears to be that we're only listing the VRF name in the selection list when the name is not required to be unique. Would it help to include the RD (which is unique) along with the VRF name?

@nonsbe
Copy link
Author

nonsbe commented May 18, 2017

Thank you for the comment!

That could be an option, but in general RDs aren't specifcly unique as well. Yes, I'm being sceptical...
You can configure the same RD on 2 non-related devices and use MP-BGP to distribute routes between VRFs on the device itself (via route-target export/import).

Also it could be more viable to attach multiple devices to a VRF, because mostly the VRF is strechted over more than one L3 device. Eg. Branch router VRF-A > L3 > Core router VRF-A > L3 > Virtual Firewall for VRF-A. They all have the same routing table and unique address space.

It some hard matter to deal with anyway, since you have that many different options and techniques.

Maybe as first implementation it could help to just include the RD and/or the Tenant Name in the selection list. See picture below
selection_252

@jeremystretch
Copy link
Member

That could be an option, but in general RDs aren't specifcly unique as well.

Each VRF must have a unique route distinguisher. This is enforced at the database level.

I'd be okay with introducing a display_name on the VRF model (similar to the rack model) which returns the VRF name concatenated with its RD, but trying to associate it with a tenant would result in too much overhead.

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Jun 8, 2017
@jeremystretch jeremystretch changed the title Duplicate VRF names bound to Tenant sites Include RD when displaying a list of VRFs in a form Jun 8, 2017
@nonsbe
Copy link
Author

nonsbe commented Jun 9, 2017

I'd be ok with that! This can already help to clarify which RD is bound to the duplicate VRF name.

I suppose you share the same opinion that there could be more related objects bound to VRFs (like Devices and Tenants). The hard thing is to pin them correctly in the architectural design of netbox and not having too much overhead while loading or storing information.

Thank you for the effort!

@jeremystretch
Copy link
Member

Added display_name to the VRF serializer in 8bcd8c4.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants