Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering of global search results #1189

Closed
candlerb opened this issue May 17, 2017 · 2 comments
Closed

Ordering of global search results #1189

candlerb opened this issue May 17, 2017 · 2 comments
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@candlerb
Copy link
Contributor

Issue type:

Feature request

This is a very minor suggestion!

The new global search facility (#159) is superb. However at the moment if you search for an individual IP address you get the results in the following order:

  • Prefixes
  • Aggregates
  • IP Addresses

I think it would be more user-friendly to display from more specific match to less specific, which would be:

  • IP Addresses
  • Prefixes
  • Aggregates

Additional suggestion: make the drop-down menu of object types arranged in the same order as the search results are displayed, for consistency.

@candlerb
Copy link
Contributor Author

A related display issue:

Searching for device via global search doesn't show its IP address in the results listing, but searching via devices page does.

Results from global search:

image

Results from search under /dcim/devices/

image

It would be nice if the global search results had the same columns as the specific searches.

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label May 17, 2017
@jeremystretch
Copy link
Member

The order of objects returned from a global search is currently not enforced. I'll change this to an OrderedDict to ensure consistency.

Searching for device via global search doesn't show its IP address in the results listing, but searching via devices page does.

We avoid pulling in too many related objects due to the breadth of the current global search implementation. For example, we also don't calculate rack utilization.

lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants