Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename NETBOX_USERNAME and NETBOX_PASSWORD configuration parameters #1375

Closed
jeremystretch opened this issue Jul 26, 2017 · 0 comments
Closed

Rename NETBOX_USERNAME and NETBOX_PASSWORD configuration parameters #1375

jeremystretch opened this issue Jul 26, 2017 · 0 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@jeremystretch
Copy link
Member

Python version: 2.7.6
NetBox version: 2.1.0

The NETBOX_USERNAME and NETBOX_PASSWORD configuration parameters can be misleading. A newcomer to NetBox might understandably infer that they somehow control how NetBox authenticates users, where in fact they relate to how NetBox authenticates to remote devices.

Now that we have NAPALM integration (#1348), we should rename these parameters to make their purpose more clear, i.e. NAPALM_USERNAME and NAPALM_PASSWORD. These will also fit better with the additional NAPALM configuration parameters proposed in #1374.
@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Jul 26, 2017
@jeremystretch jeremystretch mentioned this issue Aug 2, 2017
Merged
lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@jeremystretch
Closes netbox-community#1375: Renamed NETBOX_USERNAME and NETBOX_PASS…
329b7a1 
…WORD configuration parameters to NAPALM_USERNAME and NAPALM_PASSWORD
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch