Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectedDeviceViewSet should not require authentication #1385

Closed
jeremystretch opened this issue Aug 2, 2017 · 0 comments
Closed

ConnectedDeviceViewSet should not require authentication #1385

jeremystretch opened this issue Aug 2, 2017 · 0 comments
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Issue type: Bug report

Python version: 2.7
NetBox version: 2.1.0

The DCIM API ConnectedDeviceViewSet explicitly requires authentication:

    permission_classes = [IsAuthenticated]

This is unnecessary and should only require authentication if LOGIN_REQUIRED is True.
@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Aug 2, 2017
@jeremystretch jeremystretch mentioned this issue Aug 2, 2017
Merged
lampwins pushed a commit to lampwins/netbox that referenced this issue Oct 13, 2017
@jeremystretch
Fixes netbox-community#1385: Connected device API endpoint no longer …
c7175b7 
…requires authentication if LOGIN_REQUIRED=False
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeremystretch