Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an asset tag field to the rack model #1444

Closed
mattbostock opened this issue Aug 21, 2017 · 2 comments
Closed

Add an asset tag field to the rack model #1444

mattbostock opened this issue Aug 21, 2017 · 2 comments
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Milestone

Comments

@mattbostock
Copy link

mattbostock commented Aug 21, 2017

Issue type

[x] Feature request
[ ] Bug report
[ ] Documentation

Environment

  • Python version: N/A
  • NetBox version: 2.0.7

Description

Add fields to the rack model so that one can identify:

  • the manufacturer of the physical rack
  • the model number
  • the serial number
  • the asset tag

Use case

In the same way that it's useful to know what device type (model and manufacturer) a server is, it's also useful to know the same details for the rack:

  • serial number and asset tags helps to uniquely identify a given rack
  • manufacturer and model helps to identify a rack and track inventory
@jeremystretch
Copy link
Member

The problem with adding a RackType object analogous to DeviceType is we've already associated a type, width, and height with each individual rack. Introducing a separate model for this would allow racks of the same RackType to have different physical characteristics defined locally, which obviously wouldn't make sense. It would be possible to allow users to begin adopting the new approach at their leisure, but many would opt not to pursue it and I don't want to support two schemes for defining racks indefinitely.

Alternatively, we could add a direct association from the Rack model to the Manufacturer model, and add a model character field, but that doesn't strike me as particularly useful.

Serial number I have no problem adding. Asset tag might be problematic, as it's reasonable to assume that an asset tag will be unique across racks and devices, so we'd have to change it from a local field to a ForeignKey on a new model with its own table, which could get messy with regard to data migrations.

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Aug 21, 2017
@jeremystretch
Copy link
Member

I'm going to hold off on adding an asset tag field to the rack model for now. I'd like to gather more feedback on that feature before we implement to avoid working ourselves into a corner.

@jeremystretch jeremystretch changed the title Add 'device type', serial number and asset tag to rack model Add an asset tag field to the rack model Oct 9, 2017
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Jan 26, 2018
@jeremystretch jeremystretch added this to the v2.5 milestone Aug 3, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

2 participants