Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filter form from the browsable API #1785

Closed
jeremystretch opened this issue Dec 19, 2017 · 0 comments
Closed

Remove filter form from the browsable API #1785

jeremystretch opened this issue Dec 19, 2017 · 0 comments
Labels
type: bug A confirmed report of unexpected behavior in the application

Comments

@jeremystretch
Copy link
Member

Issue type

[ ] Feature request
[x] Bug report
[ ] Documentation

Environment

  • Python version: 3.5.2
  • NetBox version: 2.2.7

Description

When viewing an API endpoint in a web browser, NetBox returns a convenient browsable interface. Currently, this interface includes a button which brings up a modal containing all the filter options for the endpoint. Each field in this form is prepopulated with all potential values. This introduces a huge performance hit when viewing, for example, the IP addresses endpoint, as the interface_id field is pre-populated with all interfaces defined in NetBox.

Given that the available filters for each endpoint are documented separately, there is not much value in including the filter form in the browsable API. We can simply omit it from the API renderer and avoid what is in many cases a large amount of overhead and delay.

@jeremystretch jeremystretch added the type: bug A confirmed report of unexpected behavior in the application label Dec 19, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

1 participant