Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some CRUD ops on sub-items redirect browser to main page rather than to parent object that was just modified. #2303

Closed
explody opened this issue Aug 4, 2018 · 2 comments
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@explody
Copy link
Contributor

explody commented Aug 4, 2018

Environment

  • Python version: 3.6.5
  • NetBox version: 2.4-beta1 HEAD

It appears that when performing CRUD operations on a some sub-items, specifically interfaces on devices, upon hitting the final "Create/Delete" button, the user is redirected to the main page rather than back to the device.

Normal editing seems to have no issue, this seems to only occur on sub-items like interfaces.

Steps to Reproduce

Add or remove interfaces on a device, make sure to hit "Create" and not "Create and add more".

Expected Behavior

That the browser would be redirected to the device just edited.

Observed Behavior

Browser is redirected to the main NB page.

@jeremystretch
Copy link
Member

Not able to reproduce this. I get directed back to the device page as expected. Can you provide the exact steps you're taking, beginning with creating a new device?

@jeremystretch jeremystretch added the status: revisions needed This issue requires additional information to be actionable label Aug 6, 2018
@explody
Copy link
Contributor Author

explody commented Aug 6, 2018

Yeah, absolutely, I narrowed it down here as well, my original report was too vague. I've confirmed it when bulk deleting interfaces from a device. I'm directed to a confirmation page as expected, but upon confirming, I'm directed to the main page.

This does not appear to happen when using the trashcan button, only when checking boxes and hitting 'Delete'.

I could swear I hit it other spots as well, but I haven't confirmed any others

screen shot 2018-08-06 at 1 54 34 pm

screen shot 2018-08-06 at 1 54 40 pm

@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation and removed status: revisions needed This issue requires additional information to be actionable labels Aug 6, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Development

No branches or pull requests

2 participants