Search for multiple tags in url

[ossark]

Environment

• Python version: 2.7.10
• NetBox version: 2.4.4

Proposed Functionality

It would be nice to be able to search for multiple tags (or other keywords) like so:
https://netbox/api/ipam/prefixes/?tag=vpn1&tag=vpn2

This should yield a list of items that matches both tags. Currently the above URL only returns the items that match tag"vpn2".

Use Case

If one has multiple customers and wants a list of resources that affects a few specific customers this could come in handy. Also, if you want to highlight prefixes that are link nets between sites, tags are appropriate to find the link nets that span over two (or more) specific sites.

Database Changes

External Dependencies

[jeremystretch]

I'm marking this as a bug (as opposed to a feature request) as I think it's reasonable to expect that tags should work this way already.

As for the implementation, there's some discussion around different approaches here, but we'll probably just make a custom TagFilter() to be reused across all models.

[ossark]

If one would like it to be OR instead of AND. How would that me modelled? I am also seeing a case where you would want to list the items that match tag "vpn1" OR "vpn2" in a single call. I prefer the AND notation though. Not sure what is customary in REST.

[jeremystretch]

The behavior exhibited by existing filters is OR. For example, /devices/?site=foo&site=bar will return devices from either site. (The problem with the tag filter is that only the last tag specified in a list is being considered.)

I don't think there's any inherent mechanism for implying OR vs AND in django-filter.

[ossark]

I understand. What I would prefer for the "?tag=" filter is AND.

What about using the ?tag=vpn1,vpn2 construct to indicate AND?

[jeremystretch]

I've implemented this with the AND logic, such that ?tag=foo&tag=bar will return only objects with both tags assigned.

[alimoghrabi]

Is this functionality working properly? I have tested it in my environment and it doesn't seem to be returning the correct data.

[ossark]

Works for me as specified. Are you running a proper version?

…

On Thu, Apr 11, 2019 at 5:35 PM alimoghrabi ***@***.***> wrote: Is this functionality working properly? I have tested it in my environment and it doesn't seem to be returning the correct data. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2558 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AND2a1uEfQTVJt7dwvC980bX6iZn0UPNks5vf1ZZgaJpZM4YSIqz> .