Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve color picker form widget #2590

Closed
jeremystretch opened this issue Nov 14, 2018 · 1 comment
Closed

Improve color picker form widget #2590

jeremystretch opened this issue Nov 14, 2018 · 1 comment
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@jeremystretch
Copy link
Member

Environment

  • Python version: 3.5.2
  • NetBox version: 2.4.7

Proposed Functionality

Replace the stock <select> widget with something capable of displaying colors for ColorFields.

Use Case

Most browsers don't render background colors for <select> items, so the user sees only a list of colors referenced by name ("Dark red", "Red", "Pink", etc.). This makes it difficult to find the desired color, especially if you're not familiar with the more obscure colors like cyan and indigo.

Database Changes

None

External Dependencies

This might involve a third party UI package like Select2, which was also mentioned in #2516.
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application labels Nov 14, 2018
@lampwins lampwins mentioned this issue Jan 5, 2019
Closed
lampwins added a commit that referenced this issue Jan 5, 2019
@lampwins
implemented #2590 - improved color picker with actual colors
6d5d9c8
lampwins added a commit that referenced this issue Jan 5, 2019
@lampwins
#2590 changelog
72d5c6f
@lampwins
Copy link
Contributor

lampwins commented Jan 5, 2019 •
edited
Loading

This has been implemented in the select2-ui branch

@lampwins lampwins closed this as completed Jan 5, 2019
@jeremystretch jeremystretch mentioned this issue Jan 29, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lampwins @jeremystretch