Django Permission 'codenames` Duplicated

[bdlamprecht]

Environment

• Python version: 3.6
• NetBox version: v2.5-beta2

Steps to Reproduce

I'm using @cimnine's Docker deployment instructions mentioned here.
Although I couldn't get that one-liner to work for whatever reason, if I manually execute that code, I still see these permission codenames:

add_interface
add_interfaceconnection
change_interface
change_interfaceconnection
delete_interface
delete_interfaceconnection
view_interface
view_interfaceconnection
add_interfaceconnection         <- Duplicated
change_interfaceconnection      <- Duplicated
delete_interfaceconnection      <- Duplicated
view_interfaceconnection        <- Duplicated

This causes problems as it is expected for each permission to have a unique codename.

Expected Behavior

The permissions should take effect without erroring out.

Observed Behavior

When I try and bring up my Dockerized version of NetBox using v2.5-beta2, I get this error:

  File "/usr/local/lib/python3.6/site-packages/django/db/models/query.py", line 403, in get
    (self.model._meta.object_name, num)
django.contrib.auth.models.MultipleObjectsReturned: get() returned more than one Permission -- it returned 2!

[bdlamprecht]

This is a screenshot from the WebUI admin page:

You can see the duplicated permissions much easier this way.

[jeremystretch]

This is happening because we delete the InterfaceConnection model and then introduce a new InterfaceConnection proxy model in the 0066_cables DCIM migration under v2.5. For reference:

v2.4.8:

netbox=> select * from auth_permission where codename like '%interfaceconnection%';
 id  |              name               | content_type_id |          codename          
-----+---------------------------------+-----------------+----------------------------
 112 | Can add interface connection    |              38 | add_interfaceconnection
 113 | Can change interface connection |              38 | change_interfaceconnection
 114 | Can delete interface connection |              38 | delete_interfaceconnection
(3 rows)

After migrating to v2.5-beta2:

netbox=> select * from auth_permission where codename like '%interfaceconnection%';
 id  |              name               | content_type_id |          codename          
-----+---------------------------------+-----------------+----------------------------
 112 | Can add interface connection    |              38 | add_interfaceconnection
 113 | Can change interface connection |              38 | change_interfaceconnection
 114 | Can delete interface connection |              38 | delete_interfaceconnection
 315 | Can add interface connection    |              37 | add_interfaceconnection
 316 | Can change interface connection |              37 | change_interfaceconnection
 317 | Can delete interface connection |              37 | delete_interfaceconnection
 318 | Can view interface connection   |              37 | view_interfaceconnection
(7 rows)

So there are actually two issues here:

1. The content type and permissions for the old InterfaceConnection model aren't getting deleted along with the model. This appears to be normal Django behavior, but we can accomplish this manually in the migration.

2. The new proxy console/power/interface connection models are getting add/change/delete permissions created for them, which are unnecessary and unusable. I'll open a new issue for this second point.

In the meantime, this can be resolved by cleaning out stale content types with the following management command:

manage.py remove_stale_contenttypes