Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type Hint for connected_endpoint Object #2649

Closed
zachmoody opened this issue Dec 6, 2018 · 0 comments
Closed

Type Hint for connected_endpoint Object #2649

zachmoody opened this issue Dec 6, 2018 · 0 comments
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application

Comments

@zachmoody
Copy link
Contributor

Environment

  • Python version: 3.6
  • NetBox version: 2.5-beta

Proposed Functionality

Add a field that provides a hint regarding what type of connection it is. Currently we can either get a device or circuit nested object. The addition of this always-present field could lend a hint to clients about which one to expect.

Use Case

When inspecting an interface return some clients may need to explicitly know whether to expect a device or circuit nested object in connected_endpoint.

Database Changes

None I'm aware of.

External Dependencies

None.
@zachmoody zachmoody added type: feature Introduction of new functionality to the application API change labels Dec 6, 2018
@jeremystretch jeremystretch added the status: accepted This issue has been accepted for implementation label Dec 6, 2018
jeremystretch added a commit that referenced this issue Dec 6, 2018
@jeremystretch
Closes #2649: Add connected_endpoint_type to connectable device compo…
45a1dfb 
…nent API representations
@jeremystretch jeremystretch mentioned this issue Dec 10, 2018
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: feature Introduction of new functionality to the application
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zachmoody @jeremystretch