Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site addresses in "Map it" links are not properly URL encoded #2798

Closed
bgilmore opened this issue Jan 18, 2019 · 0 comments · Fixed by #2799
Closed

Site addresses in "Map it" links are not properly URL encoded #2798

bgilmore opened this issue Jan 18, 2019 · 0 comments · Fixed by #2799
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@bgilmore
Copy link
Contributor

Environment

  • Python version: 3.6.6
  • NetBox version: 2.4.6 (to HEAD)

Steps to Reproduce

  1. Add a site with an address containing a #, for example: 123 Fourth St #5, Sixton 78910
  2. Click on the "Map it" link
  3. Everything after the unescaped # is interpreted as a fragment identifier.

Expected Behavior

The physical_address field should be passed through the urlencode filter.

Observed Behavior

The physical_address field is not passed through the urlencode filter.
bgilmore added a commit to bgilmore/netbox that referenced this issue Jan 18, 2019
@bgilmore
Fixes netbox-community#2798: URL encode physical_address in links
fb0ed3d
@jeremystretch jeremystretch added type: bug A confirmed report of unexpected behavior in the application status: accepted This issue has been accepted for implementation labels Jan 18, 2019
@bgilmore bgilmore mentioned this issue Jan 18, 2019
Merged
jeremystretch added a commit that referenced this issue Jan 18, 2019
@jeremystretch
Merge pull request #2799 from bgilmore/develop
ae8c5ae 
Fixes #2798: URL encode physical_address in links
jeremystretch added a commit that referenced this issue Jan 18, 2019
@jeremystretch
Changelog for #2798
0d717cd
@jeremystretch jeremystretch mentioned this issue Jan 29, 2019
Merged
@netbox-community netbox-community locked as spam and limited conversation to collaborators Jan 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #2798: URL encode physical_address in links bgilmore/netbox
2 participants
@bgilmore @jeremystretch