Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue with Select2 and Tags with Spaces #3031

Closed
bdlamprecht opened this issue Mar 27, 2019 · 0 comments · Fixed by #3197
Closed

Issue with Select2 and Tags with Spaces #3031

bdlamprecht opened this issue Mar 27, 2019 · 0 comments · Fixed by #3197
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application

Comments

@bdlamprecht
Copy link
Contributor

Environment

  • Python version: 3.6.7
  • NetBox version: 2.5.8

Steps to Reproduce

  1. Edit a device (or any other applicable object) and add an already existing tag:
    image
  2. Select a tag to attach to device (or other object):
    image
  3. Click Update

Expected Behavior

The existing tag to be attached according to what was displayed in the WebUI

Observed Behavior

New individual tags were created for each separate word in the existing tag name:
image

The only way to work around this is to manually type the name of the tag surrounded by double-quotes:
image

I know this is documented in the section on Tags, but it doesn't exactly follow the behavior there as the WebUI is showing it will attach an existing tag (which already has spaces in the name).

This became an became an issue (I believe) when #2753 was implemented.
I'm hopeful this shouldn't be too difficult to fix, but I could be wrong (?),
@jeremystretch jeremystretch added status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application labels May 2, 2019
KhaledTo pushed a commit to KhaledTo/netbox that referenced this issue May 18, 2019
Fixes netbox-community#3031: Fix new individual tags get created when…
29e56cd 
… fetching existing tag that contains spaces
KhaledTo pushed a commit to KhaledTo/netbox that referenced this issue May 18, 2019
Fixes netbox-community#3031: Fix Select2 creates multiple tags for ta…
d18cfe8 
…gs with spaces
KhaledTo pushed a commit to KhaledTo/netbox that referenced this issue May 18, 2019
Fixes netbox-community#3031: Select2 creates multiple tags for tags w…
2079285 
…ith spaces
@KhaledTo KhaledTo mentioned this issue May 18, 2019
Merged
KhaledTo pushed a commit to KhaledTo/netbox that referenced this issue May 18, 2019
Fixes netbox-community#3031: Select2 creates multiple tags for tags w…
cbace6f 
…ith spaces
jeremystretch added a commit that referenced this issue May 29, 2019
@jeremystretch
Merge pull request #3197 from KhaledTo/bug/3031
00ffa35 
 Fixes #3031: Select2 creates multiple tags for tags with spaces
jeremystretch added a commit that referenced this issue May 29, 2019
@jeremystretch
Changelog for #3031
8b00513
@jeremystretch jeremystretch mentioned this issue May 31, 2019
Merged
@lock lock bot locked as resolved and limited conversation to collaborators Jan 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status: accepted This issue has been accepted for implementation type: bug A confirmed report of unexpected behavior in the application
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3031: Select2 creates multiple tags for tags with spaces KhaledTo/netbox
2 participants
@bdlamprecht @jeremystretch