Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Change for button placement in panels #475

Closed
WilliamMarti opened this issue Aug 16, 2016 · 3 comments
Closed

UI Change for button placement in panels #475

WilliamMarti opened this issue Aug 16, 2016 · 3 comments
Labels
type: feature Introduction of new functionality to the application

Comments

@WilliamMarti
Copy link

So it looks like the normal convention for button placement in panels is in the panel-footer in Netbox. For most areas this isn't a big deal, but the 'Interfaces' panel for Devices gets rather lengthy for some larger chassis based switches. It seems to be a fairly established UI convention to have buttons placed at the top of the resource they control.

Here is an example of what I am thinking:

capture

Now I don't have to scroll to the bottom of the page to make additions or delete selected interfaces. This also might be a good place for a "Select All" checkbox as well.

I wouldn't mind making this change, but wanted your(stretch) opinion first

@sts
Copy link

sts commented Sep 16, 2016

-1 on how this currently looks like.

I feel the buttons would rather be placed on the right side. 'Add interface' right to 'delete interface' button and the padding between those should be fixed too.

@WilliamMarti
Copy link
Author

I would be fine with having the buttons right aligned. I think the greater issue is moving the buttons to the top of the resouce

@jeremystretch jeremystretch added the type: feature Introduction of new functionality to the application label Sep 22, 2016
@jeremystretch
Copy link
Member

jeremystretch commented Sep 28, 2016

The "add <object>" buttons are now displayed in the bottom right corner of all device and device type component panels. The are also displayed in the top right corner if the panel contains more than ten objects.

if-fi pushed a commit to if-fi/netbox that referenced this issue Oct 1, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: feature Introduction of new functionality to the application
Projects
None yet
Development

No branches or pull requests

3 participants