-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interface/port buttons missing on device type #591
Labels
type: bug
A confirmed report of unexpected behavior in the application
Comments
I just noticed that I'm getting the same behavior. |
Derp. I'll try to get a fix out today. Thanks for catching this! |
jeremystretch
added
the
type: bug
A confirmed report of unexpected behavior in the application
label
Oct 3, 2016
jeremystretch
added a commit
that referenced
this issue
Oct 4, 2016
Fixes #591: Correct display of device type component creation buttons
This has been fixed in release v1.6.2-r1. Still need to apply the patch to the |
jeremystretch
added a commit
that referenced
this issue
Oct 4, 2016
Great! Thank you so much 😀 |
lampwins
pushed a commit
to lampwins/netbox
that referenced
this issue
Oct 13, 2017
…tons in device type view
lampwins
pushed a commit
to lampwins/netbox
that referenced
this issue
Oct 13, 2017
Fixes netbox-community#591: Correct display of device type component creation buttons
lampwins
pushed a commit
to lampwins/netbox
that referenced
this issue
Oct 13, 2017
…creation buttons
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In v1.6.2 the Add Interface/Console Port/etc links are missing from the device type show page. Here's what I am seeing:
And here's what I'm pretty sure I'm meant to be seeing:
Through the magic of git bisect I have identified 30c7c2d as the commit which broke this. It looks like it's the conditional on line 8 of
netbox/templates/dcim/inc/devicetype_component_table.html
... if I remove that conditional block, I get the buttons back.I'm guessing that the idea there was to make that button disappear if there were between one and ten rows in the table and then reappear if there were ten or more. If that's right, then I think that changing it to
{% if table.rows|length > 10 or table.rows|length == 0 %}
will do the trick. I can submit a PR if y'all want.The text was updated successfully, but these errors were encountered: