-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Layout improvements for IP Addresses shown under Device #878
Comments
For completeness: this would also place the management IP addresses under the management interfaces. Right now if a device has two service addresses and two ILO addresses, they are displayed as a list of 4 addresses - correctly labelled with the interface names of course, but it's up to you to infer which is management and which is service, by looking for corresponding named interfaces under "Critical Connections" and "Interfaces" respectively. Right now, the 'primary' address is flagged, but management address(es) are not flagged. This need would go if management address(es) were shown under the corresponding management interface. |
@candlerb Could you provide a mock-up please? |
Current: First proposal: I'm terrible at visual layout, but logically that's what I'd like to see - IP address(es) under each interface or management port. Notes:
|
I've also lost the "assign IP address" button. Suggestion 1: extend the "edit interface" page to allow assignment and removal of IP addresses on that interface. This also avoids having buttons next to each IP address to deassign them. Suggestion 2: add a new button on the interface for "assign IP". The problem here is possible confusion: "+" currently means "connect" rather than "add address". It could be changed to something which looks like a plug, and then use + and - to add and remove IP addresses. But "-" would have to sit next to the address itself. I think (1) is preferable from a UI point of view, as it means less buttons to choose from; but it might be more work to implement. |
Another attempt, this time just adding a table row for each IP address: HTML:
Adding |
Thanks @candlerb and @snazy2000 for the inspiration for d5c3f9e. Please review and let me know what you think. I've added a button at the top of the interfaces list to toggle the display of IP addresses. |
It's neat. I like the use of speech bubbles for the IP Description. I'd still prefer to move "Critical Connections" onto the right-hand column. Reasons:
|
Only thing if move stuff to the right is that when you have a switch that has 48 ports it will be quite far down the page. It would be cool if there was the ability to move the tiles around based on the user's needs and it then saves that to the db |
This is true, although they'd still be easy to find by scrolling to the bottom of the page, rather than being buried in the middle of the left-hand column. Alternatively, I probably wouldn't object to having the "Critical" connections at the top of the RH column. |
I'm going to keep critical connections grouped together as I like being able to see them separately. This is especially valuable for network gear with many interfaces.
True, I'll fix it so that management interface IPs are always displayed. |
This should be good for now. I'm going to close this out. We'll see what people think with the 1.9.6 release. |
A couple of suggestions for layout improvements when looking at a device
/dcim/devices/<N>/
, specifically the table of IP Addresses (shown under Secrets).Include IP Address Status
Next to each IP address, also display the IP Address Status with its coloured label.
This would be helpful because we have some deprecated addresses still associated with their original interface, and it would be good to distinguish the current and previous addresses.
Addresses in Interfaces table
Larger change:
Merge the IP Addresses table into the Interfaces table, so that the addresses are grouped under each interface.
This would make it clear to the end user that the data model associates addresses with interfaces, not directly with devices (apart from the primary addresses).
I think this would also balance the screen layout better for the server case, given that the left-hand column is very full, but the right-hand column has only interfaces (and often only one).
Of course, switches and routers have many interfaces. If they are layer 2 devices they won't have IP addresses associated with each interface, so the layout won't change. For routers, I think it's still clearer to see the interfaces with the IP address next to each one, rather than one table of addresses and a separate table of interfaces.
The text was updated successfully, but these errors were encountered: