-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
App: internal ports array attribute #570
App: internal ports array attribute #570
Conversation
I think you've got it right as it currently is. It matches how the yaml spec spec treats them:
https://www.digitalocean.com/docs/app-platform/references/app-specification-reference/
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. I left one comment in line. Think we can get rid of appSpecInternalPortSchema()
0ca2a78
to
9f718d3
Compare
9f718d3
to
ae89214
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the great contributions!
* wip * wip internal_port * wip internalPort * internal_port * internal port * internal port acc test * internal_port * internal_port * unneeded * fixup acceptance test * acceptance test * Remove unused appSpecInternalPortSchema() Co-authored-by: Matthieu Berthomé <matthieu@whisbee.eu> Co-authored-by: Andrew Starr-Bochicchio <a.starr.b@gmail.com>
The digitalocean_app spec was also missing the internal_ports attribute on a service, this should fix this. Acceptance test (
TestAccDigitalOceanApp_InternalPort
) is passinginternal_ports are specified like
internal_ports = ["5000"]
, maybe an array syntaxwould be preferred, similarly to the routes attribute. not sure.