Sauce Labs does not work from forks

[victorb]

Came across this problem in ipfs/js-ipfs#631 where I made a PR from my fork to the main repository. Since Travis would hide environment variables for forks (and rightly so), Sauce Labs could not authenticate, therefore failing the tests.

Not sure about the solution, but currently, any PR coming from a contributor not having write access to the main repository, would fail.

[dignifiedquire]

We should detect the presence of sauce labs credentials, and only then run the sauce labs tests. Relevant code is in here: https://github.com/dignifiedquire/aegir/blob/master/config/karma.conf.js#L74 which actually does this, so I'm unclear as to the issue you were seeing.

[victorb]

Not sure either, but here is the ending of one of the failed builds:

[10:48:58] Finished 'libnode:start' after 363 ms
[10:48:58] Starting 'test:browser:before'...
[10:48:58] Finished 'test:browser:before' after 7.35 μs
[10:48:58] Starting 'karma'...
29 11 2016 10:48:58.998:WARN [watcher]: Pattern "/home/travis/build/ipfs/js-ipfs/test/**/*.spec.js" does not match any file.
29 11 2016 10:48:59.000:WARN [watcher]: Pattern "/home/travis/build/ipfs/js-ipfs/test/fixtures/**/*" does not match any file.
29 11 2016 10:49:14.827:INFO [karma]: Karma v1.3.0 server started at http://localhost:9876/
29 11 2016 10:49:14.828:INFO [launcher]: Launching browsers sl_chrome, sl_firefox, sl_safari, sl_ie_11, sl_edge, sl_android, sl_iphone with concurrency 3
29 11 2016 10:49:14.840:INFO [launcher]: Starting browser Chrome 53 (Windows 10) on SauceLabs
29 11 2016 10:49:14.856:INFO [launcher]: Starting browser Firefox 48 (Windows 10) on SauceLabs
29 11 2016 10:49:14.856:INFO [launcher]: Starting browser Safari latest (OS X 10.11) on SauceLabs
29 11 2016 10:49:19.228:ERROR [launcher.sauce]: Can not start Chrome 53 (Windows 10)
  Failed to start Sauce Connect:
  Invalid Sauce Connect Credentials. 29 Nov 10:49:19 - Response: {"error": "Not authorized"}.
29 Nov 10:49:19 - Error checking overlapping tunnels.
29 Nov 10:49:19 - Cleaning up.
29 Nov 10:49:19 - Sauce Connect could not establish a connection.
29 Nov 10:49:19 - Please check your firewall and proxy settings.
29 Nov 10:49:19 - You can also use sc --doctor to launch Sauce Connect in diagnostic mode.
29 Nov 10:49:19 - Goodbye.
29 11 2016 10:49:19.230:ERROR [launcher.sauce]: Can not start Firefox 48 (Windows 10)
  Failed to start Sauce Connect:
  Invalid Sauce Connect Credentials. 29 Nov 10:49:19 - Response: {"error": "Not authorized"}.
29 Nov 10:49:19 - Error checking overlapping tunnels.
29 Nov 10:49:19 - Cleaning up.
29 Nov 10:49:19 - Sauce Connect could not establish a connection.
29 Nov 10:49:19 - Please check your firewall and proxy settings.
29 Nov 10:49:19 - You can also use sc --doctor to launch Sauce Connect in diagnostic mode.
29 Nov 10:49:19 - Goodbye.
29 11 2016 10:49:19.230:ERROR [launcher.sauce]: Can not start Safari latest (OS X 10.11)
  Failed to start Sauce Connect:
  Invalid Sauce Connect Credentials. 29 Nov 10:49:19 - Response: {"error": "Not authorized"}.
29 Nov 10:49:19 - Error checking overlapping tunnels.
29 Nov 10:49:19 - Cleaning up.
29 Nov 10:49:19 - Sauce Connect could not establish a connection.
29 Nov 10:49:19 - Please check your firewall and proxy settings.
29 Nov 10:49:19 - You can also use sc --doctor to launch Sauce Connect in diagnostic mode.
29 Nov 10:49:19 - Goodbye.


No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

The build has been terminated

Full logs are here: https://api.travis-ci.org/jobs/179722306/log.txt?deansi=true

[dignifiedquire]

I think I know the problem, becasue SAUCE_USERNAME is public it is set on travis, but the password is private so it's not set and currently aegir just checks for the username.