Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript app giving "Cannot find ESLint loader (eslint-loader)" error #221

Closed
sethreidnz opened this issue Dec 5, 2020 · 2 comments
Closed

Comments

@sethreidnz
Copy link

I have just created a new project you can find here and I get the following error flash up real quick before going to the usual create-react-app build message.

image

The above project all I've done is create a new create react app like:

create-react-app my-app --template typescript

Then followed the Craco instalation guide. I don't know that it actually affects anything. From what I can tell, eslint is working just fine, but it's a strange error to be getting. Looks like its this code here:

https://github.com/gsoft-inc/craco/blob/9f4077d8f7718158142636d47d39a862d5877df5/packages/craco/lib/features/webpack/eslint.js#L96

So I guess it's not finding that loader? A stab in the dark is that the typescript template is using typescript-eslint?

@alexasselin008
Copy link
Contributor

Hi Seth,

You can read more on this issue here : #205

Craco doesn't fully support react-scripts 4.0.0 just yet. There is a couple workaround mentionned in the linked issue.

Hope this helps

@sethreidnz
Copy link
Author

Dang I see. Yeah it seems to work, but then in a CI/CD environment it blows up. I am just going to wait because I'm just playing around with some side projects with this so no stress.

Thanks for the fast response this is a cool tool! I haven't touched create react app in about a year and this makes it so you can actually get everything you want going on, but not have to maintain a webapck build or be boxed in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants