Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Relation to NearestNeighbors.jl #6

Open
bhgomes opened this issue Apr 23, 2019 · 5 comments
Open

Question: Relation to NearestNeighbors.jl #6

bhgomes opened this issue Apr 23, 2019 · 5 comments

Comments

@bhgomes
Copy link

bhgomes commented Apr 23, 2019

I see that the interfaces are similar and that you both use the Distances.jl library for metrics. Is there any relation to this package and do you see any reason in the future to interface with them? Also, benchmarks comparing both on the same hardware would be interesting.

@dillondaudert
Copy link
Owner

This algorithm - and approximate nearest neighbor algorithms more generally - could potentially exist in NearestNeighbors.jl. The main reason I didn't pursue contributing to that package when implementing NNdescent is because the existing algorithms all output NNTrees. The output of NNdescent is a KNN graph, not a tree, so it didn't fit very naturally in that abstraction.

@dillondaudert
Copy link
Owner

As for benchmarking, adding this package to the ANN benchmarks is something I've been considering but haven't gotten around to.

@IlyaOrson
Copy link

IlyaOrson commented Nov 30, 2019

Maybe this discussion on a common API can also be fruitful for this package.

@dillondaudert
Copy link
Owner

Thanks for the heads up. I'm in the middle of redoing the underlying implementation details in this package (in the v0.3.0-dev branch), it might be worth sharing that as part of the discussion...

@chelate
Copy link

chelate commented May 21, 2024

Just a note for others, for my large and high dimensional dataset (10^6 points of dimension 30)this package is at least 10x faster than NearestNeighbors.jl and is a great help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants