Skip to content
This repository has been archived by the owner on Oct 19, 2021. It is now read-only.

Explore using stil4m/elm-syntax instead of elm-ast #17

Open
dillonkearns opened this issue Dec 15, 2018 · 3 comments
Open

Explore using stil4m/elm-syntax instead of elm-ast #17

dillonkearns opened this issue Dec 15, 2018 · 3 comments

Comments

@dillonkearns
Copy link
Owner

Using https://github.com/stil4m/elm-syntax may potentially address a few problems:

  • The elm-ast libraries have several parsing bugs
  • The elm-ast libraries are not planning on upgrading to Elm 0.19
  • Using elm-syntax may also help with only parsing modules which are imported somewhere

Here's the original comment suggesting this library: #15 (comment)

Here are some current issues in elm-typescript-interop it could address:

@davetapley
Copy link
Contributor

If #18 is merged, then FYI it will have to be updated if we move away from elm-ast.

@muelli
Copy link

muelli commented Oct 21, 2019

I'm throwing in a wild idea:
How about some manual pre-processing of the modules?
In particular, stripping -- comments to alleviate the problems experienced in #15.

Also note https://github.com/andre-dietrich/parser-combinators

@dillonkearns
Copy link
Owner Author

I suggested the manual preprocessing in a github issue a while back for the Bogdanp parsing library, but it seems like that one isn't being actively maintained lately (at least the last I checked).

I think the still4m package is the way to go. It will take some time to change things over, though and I don't have much bandwidth at the moment, but I'll go that route when I do it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants