Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge Case: hold 4 2 6, release 4 #1

Open
pauldps opened this issue Nov 15, 2018 · 0 comments
Open

Edge Case: hold 4 2 6, release 4 #1

pauldps opened this issue Nov 15, 2018 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pauldps
Copy link
Collaborator

pauldps commented Nov 15, 2018

Steps to reproduce

  • Hold 4
  • Hold 2
  • Hold 6
  • Release 4

Expected Events

  • 4
  • 1 (4 + 2)
  • 3 (2 + 6)
  • No event

What is happening instead

The last event is being sent over twice, as if repeating the last input, when it's not the case.

Suggested Fix

The real directional event is always based on the last two inputs being held.

When a direction is released, do not dispatch any event if its index is not part of the two last items.

@pauldps pauldps self-assigned this Nov 15, 2018
@pauldps pauldps added the bug Something isn't working label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant