Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not explicitly set rkyv pointer size #1449

Open
arbor-arthur opened this issue Oct 18, 2024 · 0 comments
Open

Do not explicitly set rkyv pointer size #1449

arbor-arthur opened this issue Oct 18, 2024 · 0 comments

Comments

@arbor-arthur
Copy link

Cargo.toml currently sets rkyv-serialize-no-std = ["rkyv/size_32"] which prevents using rkyv with any other pointer size. It is best practice for libraries to not set the pointer size and allow binaries to choose the pointer size themselves. For myself, I patched this to rkyv-serialize-no-std = ["rkyv"], although I imagine that testing might require it to still be set in some circumstances?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant