Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Menu item stays visible #715

Closed
devshisiyani opened this issue Jan 11, 2015 · 1 comment
Closed

Share Menu item stays visible #715

devshisiyani opened this issue Jan 11, 2015 · 1 comment

Comments

@devshisiyani
Copy link

On android phone using phonegap, I have successfully managed to add my own hooks to the share menu buttons. I have managed to get the download image and share buttons working. One issue I have is that when the share menu item is clicked the share menu item stays up and is visible. When I move to the next image the menu item is still visible and displayed. When this visible down load button is selected again the previous image is selected and downloaded. This does not happen on chrome browser only android phones. Not sure how to close down the share menu Item when the next image is selected using finger swipe. The menu is only removed if you tap on the image which appears to refresh the page and the menu item disappears.

How can get rid of the menu item when the user moves onto the next image using finger swipe.

Thank for you help.

@dimsemenov
Copy link
Owner

So you're saying that after share modal is open, tap on dark overlay refreshes the page? Please get unmnified version of UI and debug why it refreshes the page, function that redirects to sharing website is _openWindowPopup https://github.com/dimsemenov/PhotoSwipe/blob/master/dist/photoswipe-ui-default.js#L191

How can get rid of the menu item when the user moves onto the next image using finger swipe.

"Hide share modal during swipe gesture" will be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants