Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typos in Wiki #21

Closed
rolfnl opened this issue Apr 29, 2014 · 1 comment
Closed

Typos in Wiki #21

rolfnl opened this issue Apr 29, 2014 · 1 comment

Comments

@rolfnl
Copy link

rolfnl commented Apr 29, 2014

I think we can't fork the wiki to send pr's, am I correct?

https://github.com/dingo/api/wiki/Internal-Requests
Here it says: Tthe api facade [...]

https://github.com/dingo/api/wiki/Returning-Errors
Here it says under Custom Exceptions:
[...]
return new Response($response, 401);

I think this should be:
return new Dingo\Api\Http\Response($response, 401);

yay?

Cheers
@jasonlewis
Copy link
Contributor

Cheers. I've locked the Wiki down for the time being but do plan on opening it up. Just need to get things in order first. Fixed the mistakes. Thanks. 😄

@xLink xLink mentioned this issue Dec 3, 2014
Closed
@bfmbrandonjames bfmbrandonjames mentioned this issue Jan 4, 2016
Closed
wayne5w referenced this issue Mar 17, 2016
@jasonlewis
Inject a new router instance into the Laravel adapter.
de7bbb4 
Instead of using the existing Laravel router we will use a new instance. This
should prevent the APIs internal dispatcher from overriding the current route
on the actual Laravel router instance.

There does not seem to be any need for the router instance that is injected
into the adapter to be the actual Laravel router, as the adapter just needs
an instance to dispatch the API-only routes.
@hananfauzi hananfauzi mentioned this issue Mar 29, 2016
Closed
@banandam banandam mentioned this issue Apr 21, 2016
Closed
@tankhit tankhit mentioned this issue May 16, 2016
Closed
@tankhit tankhit mentioned this issue Aug 8, 2016
Closed
@cclep cclep mentioned this issue Aug 30, 2016
Merged
@fico7489 fico7489 mentioned this issue Jan 19, 2017
Closed
@imlewc imlewc mentioned this issue Feb 16, 2017
Closed
@sourabhkum sourabhkum mentioned this issue Aug 10, 2017
Closed
@north9527 north9527 mentioned this issue Sep 4, 2017
Closed
@lear2012 lear2012 mentioned this issue Oct 1, 2017
Closed
@winkull winkull mentioned this issue Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rolfnl @jasonlewis