Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-use buffer after opening blame commit to prevent polluting the jumplist? #6

Open
gstokkink opened this issue Aug 21, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@gstokkink
Copy link
Contributor

gstokkink commented Aug 21, 2022

First of all, nice plugin! It seems to replace both vim-fugitive and vim-rhubarb.

I noticed a small issue after opening a blame commit (original mapping: <CR>). In vim-fugitive, I could simply use the alternative file command (default CTRL-^) to return to the original file after opening the blame commit.. However, this does not seem to work with your plugin. Turns out your plugin creates a new buffer (I think, not sure) instead, which also adds an entry to the jumplist. Obviously I could then use CTRL-O instead to return the original file, but maybe it's better to re-use the existing buffer instead, and not add an entry to the jumplist. Especially since you end up with an empty buffer when jumping back to the blame commit through the jumplist.

Hopefully my explanation is clear :)

@dinhhuy258
Copy link
Owner

dinhhuy258 commented Aug 22, 2022

Thank you for creating the issue. Your explanation is obvious; I can reproduce it on my machine... I will have a look and have an improvement soon... Thank you...

@dinhhuy258 dinhhuy258 added the enhancement New feature or request label Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants