Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scrollToId should accept number | string. currently only accepts number. #134

Open
mateodelnorte opened this issue Jul 1, 2020 · 0 comments · May be fixed by #135
Open

scrollToId should accept number | string. currently only accepts number. #134

mateodelnorte opened this issue Jul 1, 2020 · 0 comments · May be fixed by #135

Comments

@mateodelnorte
Copy link

Hi there. Thanks for this library.

It looks like the signature for scrollToId should either accept NodeId as a parameter or both string || number as NodeId may be a string or a number:

https://github.com/diogofcunha/react-virtualized-tree/blob/master/index.d.ts#L6

It currently only accepts number.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensuring consistent interface for scrollToId mateodelnorte/react-virtualized-tree
1 participant
@mateodelnorte