-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRAFT: Add Transonic + {Pythran, Cython} #12
Draft
ashwinvis
wants to merge
13
commits into
dionhaefner:master
Choose a base branch
from
ashwinvis:enh/transonic
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc: @serge-sans-paille and @paugier if you are interested |
…ng nested functions" This reverts commit ba03d48.
The serge-sans-paille/pythran#1951 PR has fixed nearly all issues with this benchmark pip install -e 'git+https://github.com/serge-sans-paille/pythran.git@fix/isoneutral#egg=pythran' Commit: serge-sans-paille/pythran@d305e4a
ashwinvis
changed the title
DRAFT: Add Transonic + Pythran
DRAFT: Add Transonic + {Pythran, Cython}
Jan 1, 2022
…_energy Pythran stderr: WARNING: Compilation error, trying hard to find its origin... CRITICAL: You shall not pass! E: integrate_tke.py:32:10 error: Invalid argument type for function call to , no overload found, tried:
isoneutral_diffusion_pre_64ae2fbfb04321d92f82433831349a7a_f0f3aef9981d2f876201da9bbb8ae39b.py:26:24: Cannot convert 'npy_intp *' to Python object
Pythran stderr: WARNING: Compilation error, trying hard to find its origin... CRITICAL: You shall not pass! E: integrate_tke.py:18:14 error: Dimension mismatch when slicing ---- z_index = np.arange(a.shape[2])[np.newaxis, np.newaxis, :] ^~~~ (o_0) ----
👋 @ashwinvis, thanks for the implementation. This looks really high quality. I'm just curious: could you share your experience with running the benchmarks through Transonic so far? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9
Notes: