Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics are outdated/empty #1098

Closed
droserasprout opened this issue Sep 6, 2024 · 16 comments · Fixed by #1131
Closed

Prometheus metrics are outdated/empty #1098

droserasprout opened this issue Sep 6, 2024 · 16 comments · Fixed by #1131
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation
Milestone

Comments

@droserasprout
Copy link
Member

droserasprout commented Sep 6, 2024

Prometheus metrics in dipdup.prometheus are outdated. Some of them need to be dropped, some synced with dipdup.env._MetricManager.

@droserasprout droserasprout added bug Something isn't working documentation Improvements or additions to documentation good first issue labels Sep 6, 2024
@jafeth-jimenez-c

This comment was marked as outdated.

@droserasprout droserasprout mentioned this issue Sep 13, 2024
18 tasks
@droserasprout

This comment was marked as outdated.

@Jemiiah

This comment was marked as outdated.

This comment was marked as outdated.

@droserasprout

This comment was marked as outdated.

@Jemiiah

This comment was marked as outdated.

@martinvibes

This comment was marked as outdated.

This comment was marked as outdated.

@Jemiiah

This comment was marked as outdated.

@petersdt

This comment was marked as outdated.

@martinvibes

This comment was marked as outdated.

@bigherc18

This comment was marked as outdated.

@tosoham

This comment was marked as outdated.

@bigherc18
Copy link
Contributor

I'll start working on this issue now that the other one is ready enough !

@bigherc18
Copy link
Contributor

I was writing a comment detailing the different metrics and what we should do about them but I lost it due to a computer restart, I'll write it again soon but before that I want to ask a question, what do you guys think of making performance._MetricManager the only metrics manager class and the only way we handle metrics, then prometheus metrics would be generated automatically to export the metrics in performance._MetricManager ?

@droserasprout
Copy link
Member Author

@bigherc18 Yes, it would be great to get rid of hardcoded prometheus metrics in favor of some generator around _MetricManager. A separate implementations for Prometheus and API/reports was useful before the stabilization of latter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants