fix(Changelogs): storyId as string, fix parse last line #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feverqwe
force-pushed
the
changeChangelogsPraser
branch
from
c9742e2 to
8674727
Compare
vsesh
reviewed
Jan 17, 2024
| log.error(`Changelog block must be closed${filepath ? ` in ${bold(filepath)}` : ''}`); | ||
| break; | ||
| } | ||
| let endPos = endBlockPos + BLOCK_END.length; | ||
| if (result[endPos + 1] === '\n') { |
There was a problem hiding this comment.
I suppose you should add a test about it
Feverqwe
force-pushed
the
changeChangelogsPraser
branch
from
b508d29 to
f30b6ec
Compare
vsesh
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse storyId as string
Fix parse changelogs, when close block without new line after