Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selection sort.py #120

Open
diptangsu opened this issue Sep 30, 2020 · 6 comments
Open

Fix selection sort.py #120

diptangsu opened this issue Sep 30, 2020 · 6 comments

Comments

@diptangsu
Copy link
Owner

Add a proper function and add the sorting code in the function.

User if __name__ == '__main__': and write a few lines of code with a simple example.

@UbadahJ
Copy link
Contributor

UbadahJ commented Sep 30, 2020

I would like to take this issue

@UbadahJ
Copy link
Contributor

UbadahJ commented Sep 30, 2020

Most of the python files in repo don't have type annotations, should I add them or go without them?

@diptangsu
Copy link
Owner Author

@UbadahJ Adding type annotations would be amazing!

@UbadahJ
Copy link
Contributor

UbadahJ commented Sep 30, 2020

Adding annotations to current python file. Should I create a issue to add annotations to every python file?

@diptangsu
Copy link
Owner Author

@UbadahJ I thought I would take care of it haha. But I'm not getting much time to go through the code. If you want you can add an issue, if someone else does it for me, who am I to stop them? 😆

@UbadahJ
Copy link
Contributor

UbadahJ commented Sep 30, 2020

I have added a new issue for that, just assign that to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants