New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

num_obs check and dynamic setting #774

Open

ColinOrionChandler opened this issue Jan 14, 2025 · 1 comment

Collaborator

ColinOrionChandler commented Jan 14, 2025

Dynamically adjusting num_obs would be great, like a fraction, as the numbers will vary for Rubin especially.

Also, as a bare minimum, let's throw an exception if num_obs is > than number of images.

jeremykubica mentioned this issue

Add a check the num_obs is valid #778

Merged

Collaborator

jeremykubica commented Jan 17, 2025

There are two ways we could set this dynamically:

We overload min_obs so that if it is (0.0, 1.0) it is treated as a fraction. The concern is that this could cause confusion with the user since the parameter means two different things.
We could add another parameter fraction_obs which specified min_obs as a fraction. The question is what to do if both are given? Take the smaller one? Give an error?

Do you have preferences?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment