Skip to content
This repository has been archived by the owner on Aug 28, 2020. It is now read-only.

Settings#update() returns the wrong data #1114

Open
1 of 2 tasks
bdistin opened this issue Jul 22, 2020 · 0 comments
Open
1 of 2 tasks

Settings#update() returns the wrong data #1114

bdistin opened this issue Jul 22, 2020 · 0 comments
Labels
Bug: Confirmed Issues that report confirmed bugs. Mod: SettingsGateway Issues and PRs related to SettingsGateway. Status: Help Wanted Issues that need assistance from volunteers or PRs that need help to proceed.

Comments

@bdistin
Copy link
Contributor

bdistin commented Jul 22, 2020

Describe the issue

Settings#update() is returning a string for the updated.next value instead of a role when doing something like conf set adminRole someRoleID. This makes the serializer.stringify method return undefined because string.name is not defined.

Expected and actual behavior

updated.next should be a Role on a Role setting such that serializer.strinigfy returns the role name instead of undefined.

Further details

  • @klasa/core version: 0.0.3-dev
  • node.js version: 14.5.0
  • Klasa version: 0.6.0-dev
  • I have modified core files.
  • I have tested the issue on latest build branch.
@CyberiumShadow CyberiumShadow added Bug: Confirmed Issues that report confirmed bugs. Mod: SettingsGateway Issues and PRs related to SettingsGateway. Status: Help Wanted Issues that need assistance from volunteers or PRs that need help to proceed. labels Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug: Confirmed Issues that report confirmed bugs. Mod: SettingsGateway Issues and PRs related to SettingsGateway. Status: Help Wanted Issues that need assistance from volunteers or PRs that need help to proceed.
Projects
None yet
Development

No branches or pull requests

2 participants