Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent multiple teams from using different hashes/IDs but the same name #82

Open
int00h5525 opened this issue Oct 18, 2019 · 6 comments
Labels
good first issue mothd Related to the MOTHd production server

Comments

@int00h5525
Copy link
Contributor

More than one team can use the same team name but different hashes. They shouldn't

image

@nealey
Copy link
Member

nealey commented Oct 25, 2019

This probably doesn't need to be a bulletproof solution; one with a race condition would be okay since the exploit behavior is the current behavior, which is easily fixed by hand-editing team names.

Something like, if this is a team that hasn't registered yet, open every registered team file, compare the contents against the current team, fail with "team name already taken" if there's a match. Else fall through to current behavior.

@int00h5525 int00h5525 added the mothd Related to the MOTHd production server label Feb 28, 2020
@nealey
Copy link
Member

nealey commented Nov 2, 2020

I would also accept a solution that runs client-side. While a client-side solution could be pretty easily bypassed by a determined attacker, this is not a serious attack, and in general I'm a fan of allowing participants to cause creative mayhem, especially when the administrative fix is both trivial and documented.

@nealey
Copy link
Member

nealey commented Apr 14, 2021

I now think this should be client-side. The client already has the state object, and can do a quick check to see if a team name is already in use.

@int00h5525
Copy link
Contributor Author

That depends. Is this a client-server contract issue, as far as the server guaranteeing that teams have different names, or just an annoyance that a given client may or may not choose to care about?

@nealey
Copy link
Member

nealey commented May 29, 2021

Just an annoyance. It's happened maybe six times in the last 12 years. Won't fix.

@nealey nealey closed this as completed May 29, 2021
@nealey
Copy link
Member

nealey commented May 29, 2021

I should note, though, the client pulls state before login now so the client side fix should be simple. So I guess I'll leave this open.

@nealey nealey reopened this May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue mothd Related to the MOTHd production server
Projects
None yet
Development

No branches or pull requests

2 participants