Promises v3 Checklist

[valzargaming]

Per https://github.com/reactphp/promise/releases/tag/v3.0.0

Irrelevant:

• Existing instances of FulfilledPromise and RejectedPromise classes must be updated to use resolve() and reject() functions instead
• Existing instances of LazyPromise should be removed
• Any instances of some(), map(), and reduce() functions must be replaced with the any() or all() functions (I don't think we use these)

Breaking changes:

• ExtendedPromiseInterface and CancellablePromiseInterface no longer exist, existing implementations should just be PromiseInterface #1150 - Instances of existing code explicitly typecasting ExtendedPromiseInterface should be removed.
• Existing instances of resolve() and reject() needed to be updated to match the new templates of resolve(T $value): PromiseInterface<T> and reject(Throwable $reason): PromiseInterface<never> #1151 - Instances of existing code need to call resolve or reject and handle errors appropriately.
• Existing instances of done() must be replaced with the new rejection handling system #1152 - Instances of existing code need to be replaced with then and resolved.

Non-breaking changes:

• otherwise() and always() are deprecated, replaced by catch() and finally() (only instance I could find was Discord.php)

[key2peace]

All this should be in https://github.com/discord-php/DiscordPHP/tree/promise-v3 now

[valzargaming]

ExtendedPromiseInterface extends PromiseInterface, and Promise v2 implements ExtendedPromiseInterface, so instead of replacing the existing typehinting to PromiseInterface we could just use React\Promise\Promise, which would overcome the hurdle and be better for futureproofing code. This seems to be the ReactPHP developers' intent as well, given they have made all classes final to encourage composition.

[shehi]

It's painful to read this @valzargaming :) Code-ify more please.

[valzargaming]

It's painful to read this @valzargaming :) Code-ify more please.

This is already coded in the promises v3 branch as of today.

[2colours]

What's the state of this issue?

[valzargaming]

We will not be updating to promises v3 until our dependencies can support it. The only alternative would be to rewrite all of those dependencies ourselves, going through the composer requirements one at a time to find them, manually recreate them with the changes, and then maintain them going forward, which is not something we are willing to commit to at this time.

[2colours]

What are the dependencies in question? I was very much under the impression that it's all DiscordPHP stuff. If there are such external dependencies at all, it would make sense to open issues for them at least for tracking.

[2colours]

I couldn't resist going through the "bottleneck" dependencies:

• discord-php/http (constraint: ^2.2)
  • this is under your control
• react/datagram (constraint: ~2.1)
  • DiscordPHP directly depends on an outdated version (1.5) of this library
  • DiscordPHP itself should be updated to a more recent version that does support more recent versions of react/promise

That's all I can see with composer show --tree. It doesn't seem like there is any external blocker - in fact, the biggest blocker is the direct dependency on another outdated react package (react/datagram). Maybe the issue should be about upgrading react/datagram, then.

UPDATE:
Sorry, this was for v7. For v10, react/datagram is upgraded and the only problem is the direct dependency on v2 in your own package discord-php/http.

[valzargaming]

wyrihaximus/react-cache-redis still relies on react/promise ^2.8 and is the biggest change to the v10 release.

[valzargaming]

UPDATE: Sorry, this was for v7. For v10, react/datagram is upgraded and the only problem is the direct dependency on v2 in your own package discord-php/http.

@2colours, thanks for checking and confirming this! I announced on 9/25/2024 in our Discord that we have officially discontinued v7 support specifically for reasons like this along with Discord having marked the v7 gateway as deprecated. We will not take into consideration any issues with that older version when working on this future update. The HTTP library has an active PR that is undergoing review. Once we've confirmed functionality we will add ^3.0 to composer.json.

[2colours]

wyrihaximus/react-cache-redis still relies on react/promise ^2.8 and is the biggest change to the v10 release.

The two most recent versions of that package do support v3 Promises (the latest version, 4.5.0 at this moment, only supports that).

But anyway, most importantly, this is just a dev dependency. A dev dependency really shouldn't poison downstream users; I don't know how Composer works under the hood but it rather sounds like their issue if this can happen at all.

I announced on 9/25/2024 in our Discord that we have officially discontinued v7 support specifically for reasons like this along with Discord having marked the v7 gateway as deprecated.

You mean, the server I was banned from while trying to clarify #1208, why it's a library issue and not a "you problem" to swallow promise rejections, for mere ego reasons in my opinion? That's too bad, especially that this is a general purpose PHP Discord, not just a Discord for your library. Give people power to see their true nature...

[valzargaming]

wyrihaximus/react-cache-redis still relies on react/promise ^2.8 and is the biggest change to the v10 release.
But anyway, most importantly, this is just a dev dependency. A dev dependency really shouldn't poison downstream users; I don't know how Composer works under the hood but it rather sounds like their issue if this can happen at all.

You seem to have misunderstood the context here. The inclusion of the experimental interface is intentional and serves to notify developers of its experimental nature. This is why it’s currently restricted to dev usage, it’s not yet considered stable. While we originally planned to launch the stable version with v10, we chose to delay it to ensure its readiness.

You mean, the server I was banned from while trying to clarify #1208, why it's a library issue and not a "you problem" to swallow promise rejections, for mere ego reasons in my opinion? That's too bad, especially that this is a general purpose PHP Discord, not just a Discord for your library. Give people power to see their true nature...

This issue appears to be more about individual circumstances than the library itself. If you’d like to revisit the situation, you’re welcome to submit an unban request to maintainers@discordphp.org for review and explain why you were banned and why it should be lifted. Be sure to include your discord username or id.

Regarding your concerns, the purpose of the Discord server is to facilitate constructive discussions about this library and related topics. While it is a general-purpose PHP Discord, specific communities (like ours) often set their own guidelines and moderation standards. The decision to enforce a ban was not personal but based on the observed tone and interactions. Constructive dialogue is always encouraged, but communication should remain respectful and collaborative. GitHub's issue tracker remains open for technical discussions about the library itself, provided the conversation stays professional and focused on solutions. However, I will warn you that you should adjust your tone going forward. In this thread alone you have made ad hominem attacks and made statements that escalate conflict rather than facilitate resolution (e.g. Give people power to see their true nature...). Such behavior will not be tolerated within the Discord server.

[valzargaming]

All necessary changes have been completed and have been tested in a production environment. React/Promise ^3 is now live on dev-master for testing. Closing this issue for now, please open a new issue report if any problems are found.