Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slash Command Feedback Master List #2490

Closed
20 tasks done
msciotti opened this issue Jan 15, 2021 · 3 comments
Closed
20 tasks done

Slash Command Feedback Master List #2490

msciotti opened this issue Jan 15, 2021 · 3 comments

Comments

@msciotti
Copy link
Contributor

msciotti commented Jan 15, 2021

Thank you all for all the responses and feedback you've given us about Slash Commands during this beta period. GitHub is great for tracking issues, but can sometimes be hard at a glance to understand the status of them without digging through tons of comments and swapping between open/closed.

This issue will serve as a "master list" that shows:

  • What we have committed to doing
  • What is still in discussion/decision mode
  • What we are not doing right now, and why

This issue will be locked for comments since it's just a centralized repo.

Bugs We're Squishing

Features We're Adding

Still in Discussion

What We're Not Doing Right Now, and Why

@discord discord locked and limited conversation to collaborators Jan 15, 2021
@msciotti msciotti pinned this issue Jan 15, 2021
@msciotti
Copy link
Contributor Author

What's going on this week? (OK, it was last week)

We've been hard at work responding to developer feedback on slash commands. A number of slash command related fixes and small improvements have gone out in the last week, with more significant improvements planned. All of these changes have been completed and merged, but may not yet be deployed on all platforms yet.

  • Feature: Bulk update commands via PUT
  • Improvement: Ordering of options is now preserved Position property for option hierarchy #2385
  • Improvement: User selection is no longer limited to current channel Slash commands - Inconvenient usage of user option #2353
  • Improvement: Snowflake values are supported for user/role/channel options
  • Fix: Empty slash commands args on mobile Slash command Arguments not required on mobile #2411
  • Fix: Prevent sending a slash command as plain text if it is typed really fast
  • Fix: Pressing enter mid-pill breaks chat under certain conditions
  • Fix: Pressing tab to insert an option won't pill-ify text in some cases
  • Fix: In some cases the correct application icon was not shown
  • Fix typing subcommands when two commands share same root name (there's a github issue for this I just can't find it)
  • Fix: Prevent executing giphy/tenor commands when they have no results
  • Fix: Allow mentions and channels to be used as string choices
  • Fix: Android autocomplete flashes when tapping an item to complete a parameter

@msciotti
Copy link
Contributor Author

msciotti commented Feb 4, 2021

Hey hey hey! Sorry for the late update. Here is what we've accomplished last week and this week in the world of Slash Commands. Last week was mostly bug fixes because there's some big stuff coming soon 👀

  • Feature: Support for global commands in DMs - docs & client changes coming soon
  • Improvement: Android displays full command used
  • Improvement: Arguments are validated on server side
  • Fix: Choices named like channels/mentions are invalid (A choice type 3 (string) named like a channel is not a valid choice #2341)
  • Fix: Properly handle falsey choice values for slash commands
  • Fix: Desktop built-ins that send a chat message will work in replies (/shrug, /tableflip, etc.)
  • Fix: Desktop slash commands option styles nits
  • Fix: Android command validation errors show properly
  • Fix: Android two bots with the same command always chooses the first
  • Fix: Android crash when changing the autocomplete param value of a command with multiple required options
  • Fix: Android mentionable highlight breaks pills
  • Fix: Issues with Android command discovery pagination
  • Fix: Restrict applications.commands.update to client credentials flow only
  • Accessibility: Add labels for list items and popup on Android

@msciotti
Copy link
Contributor Author

msciotti commented Feb 18, 2021

Hey hi hello. Back with your not-quite-weekly update about what's been going on!

New Features

  • Support for slash commands in DMs!
  • A new "Use Slash Commands" permission has been rolled out, allowing you to turn off non-built-in commands on a guild or channel
  • Server-side validation is complete, deployed on desktop, and rolling out on mobile
  • Check out the new UI changes coming 👀 Changes to interaction responses and flags #2615
  • resolved has been shipped! Enjoy your new objects

Improvements

  • We've raised some limitations on choices, options and removed minimum command name limit (documentation + toplevel command increase to come)
  • option type is now included in interaction payload; will roll out with the server-side validation changes
  • We no longer automatically insert @ or # after user, role, or channel arguments. No more @@ fat-fingering
  • iOS displays full command used

Bug Fixes

@typpo typpo unpinned this issue Apr 28, 2021
@typpo typpo closed this as completed Apr 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants