Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(authorize): remove implicit token grant response type #273

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

gabemeola
Copy link
Member

Fixes: #47

This was never supported and errored in unnatural ways.

@gabemeola gabemeola requested review from afgiel and matthova October 22, 2024 19:36
@gabemeola gabemeola changed the title fix(authorize): remove token response type fix(authorize): remove implicit token grant response type Oct 22, 2024
Copy link
Contributor

@matthova matthova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per convo, pedantically, this is a breaking change, but holistically, this is not a breaking change because this flow within the Discord client was never functional

@gabemeola gabemeola merged commit f45973b into main Oct 23, 2024
4 checks passed
@gabemeola gabemeola deleted the gm/no-token-response_type branch October 23, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The client throws an error when response_type is token in command AUTHORIZE
2 participants