Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Routes): voice state endpoint #1046

Merged
merged 11 commits into from
Aug 16, 2024

Conversation

imnaiyar
Copy link
Contributor

@imnaiyar imnaiyar commented Aug 7, 2024

Please describe the changes this PR makes and why it should be merged:

If applicable, please reference Discord API Docs PRs or commits that influenced this PR:

Copy link

vercel bot commented Aug 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-api-types ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 11:58pm

@imnaiyar
Copy link
Contributor Author

imnaiyar commented Aug 7, 2024

Also I'm not sure if we should rename GatewayVoiceState type (possibly to APIVoiceState ?) now that it is possible to get it over http

@vladfrangu
Copy link
Member

Also I'm not sure if we should rename GatewayVoiceState type (possibly to APIVoiceState ?) now that it is possible to get it over http

Yes, and deprecating the gateway alias

@imnaiyar
Copy link
Contributor Author

imnaiyar commented Aug 7, 2024

Also I'm not sure if we should rename GatewayVoiceState type (possibly to APIVoiceState ?) now that it is possible to get it over http

Yes, and deprecating the gateway alias

Did that if you wanna have a look

rest/v10/index.ts Outdated Show resolved Hide resolved
@imnaiyar imnaiyar requested a review from TAEMBO August 7, 2024 17:03
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the REST types, which should be added to rest/voice.ts to match the Discord docs

The patch endpoint types are in rest/guild.ts, which should be moved to rest/voice.ts as well. Not sure if we'd have to add a re-export on the patch types in rest/guild.ts since users can import individual files too

@imnaiyar imnaiyar requested a review from almeidx August 7, 2024 17:38
@imnaiyar
Copy link
Contributor Author

imnaiyar commented Aug 7, 2024

Missing the REST types, which should be added to rest/voice.ts to match the Discord docs

The patch endpoint types are in rest/guild.ts, which should be moved to rest/voice.ts as well. Not sure if we'd have to add a re-export on the patch types in rest/guild.ts since users can import individual files too

not re-exporting from guild.ts right now, we can wait for others to see what they want to do

@vladfrangu
Copy link
Member

since users can import individual files too

No, they cannot. So moving exports from the right file is perfectly fine

@vladfrangu vladfrangu merged commit 1b1a865 into discordjs:main Aug 16, 2024
6 checks passed
@imnaiyar imnaiyar deleted the feat/userState-route branch August 16, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants